Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue#6461] Fix cargo commands list #6462

Merged
merged 3 commits into from
Dec 20, 2018
Merged

[issue#6461] Fix cargo commands list #6462

merged 3 commits into from
Dec 20, 2018

Conversation

pavel-zhigulin
Copy link
Contributor

@pavel-zhigulin pavel-zhigulin commented Dec 19, 2018

Fixes #6461 - cargo autocompletion script

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pavel-zhigulin pavel-zhigulin changed the title [issue#6161] Fix cargo commands list [issue#6461] Fix cargo commands list Dec 19, 2018
@pavel-zhigulin
Copy link
Contributor Author

Wrong issue number in commit(

@Eh2406
Copy link
Contributor

Eh2406 commented Dec 19, 2018

I don't know this code.
@bors: delegate=@ehuss

@bors
Copy link
Contributor

bors commented Dec 19, 2018

✌️ @@ehuss can now approve this pull request

src/etc/cargo.bashcomp.sh Outdated Show resolved Hide resolved
@pavel-zhigulin
Copy link
Contributor Author

Updated

@dwijnand
Copy link
Member

What was the original cause and how does this fix it? I can't decipher it from the diff.

src/etc/cargo.bashcomp.sh Outdated Show resolved Hide resolved
@ehuss
Copy link
Contributor

ehuss commented Dec 19, 2018

What was the original cause and how does this fix it? I can't decipher it from the diff.

This was caused by #5807. It was getting confused by the descriptions.

@dwijnand
Copy link
Member

Oh, that 5807 guy...

@pavel-zhigulin
Copy link
Contributor Author

Remove tail call.

@dwijnand
Copy link
Member

@bors: r=ehuss

@bors
Copy link
Contributor

bors commented Dec 20, 2018

📌 Commit 56fec5c has been approved by ehuss

@bors
Copy link
Contributor

bors commented Dec 20, 2018

⌛ Testing commit 56fec5c with merge d35f1bd...

bors added a commit that referenced this pull request Dec 20, 2018
[issue#6461] Fix cargo commands list

Fixes #6461 -  cargo autocompletion script
@bors
Copy link
Contributor

bors commented Dec 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: ehuss
Pushing d35f1bd to master...

@bors bors merged commit 56fec5c into rust-lang:master Dec 20, 2018
@pavel-zhigulin pavel-zhigulin deleted the fix_issue_––#6461 branch December 20, 2018 12:57
bors added a commit to rust-lang/rust that referenced this pull request Jan 4, 2019
Update cargo

24 commits in 0d1f1bbeabd5b43a7f3ecfa16540af8e76d5efb4..34320d212dca8cd27d06ce93c16c6151f46fcf2e
2018-12-19 14:45:14 +0000 to 2019-01-03 19:12:38 +0000
- Display environment variables for rustc commands (rust-lang/cargo#6492)
- Fix a very minor race condition in `cargo fix`. (rust-lang/cargo#6515)
- Add a high-level overview of how `fix` works. (rust-lang/cargo#6516)
- Add dependency `registry` to `cargo metadata`. (rust-lang/cargo#6500)
- Fix fingerprint calculation for patched deps. (rust-lang/cargo#6493)
- serialize version directly (rust-lang/cargo#6512)
- use DYLD_FALLBACK_LIBRARY_PATH for dylib_path_envvar on macOS (rust-lang/cargo#6355)
- Fix error message when resolving dependencies (rust-lang/cargo#6510)
- use PathBuf in cargo metadata (rust-lang/cargo#6511)
- Fixed link to testsuite in CONTRIBUTING.md (rust-lang/cargo#6506)
- Update display of contents of Cargo.toml (rust-lang/cargo#6501)
- Update display of contents of Cargo.toml (rust-lang/cargo#6502)
- Fixup cargo install's help message (rust-lang/cargo#6495)
- testsuite: Require failing commands to check output. (rust-lang/cargo#6497)
- Delete unnecessary 'return' (rust-lang/cargo#6496)
- Fix new unused patch warning. (rust-lang/cargo#6494)
- Some minor documentation changes. (rust-lang/cargo#6481)
- Add `links` to `cargo metadata`. (rust-lang/cargo#6480)
- Salvaged semver work (rust-lang/cargo#6476)
- Warn on unused patches. (rust-lang/cargo#6470)
- don't write a an incorrect rustc version to the fingerprint file (rust-lang/cargo#6473)
- Rewrite `login` and registry cleanups. (rust-lang/cargo#6466)
- [issue#6461] Fix cargo commands list (rust-lang/cargo#6462)
- Restrict registry names to same style as package names. (rust-lang/cargo#6469)
@ehuss ehuss added this to the 1.33.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash autocomplete does not work correctly
6 participants